Fix cc32xx gpio driver to prevent spurious interrupts in gpio_basic_api test #22850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the gpio isr, gpio interrupts are disabled when invoking the registered callbacks. This is unnecessary, and causes a problem if the callback attempts to disable gpio interrupts by reconfiguring the pin as in the test gpio_basic_api. Fixes zephyrproject-rtos#22847 Signed-off-by: Vincent Wan <vincent.wan@linaro.org>
vanti
force-pushed
the
gpio_test_failed
branch
from
a5c1c7c to
207f715
Compare
pabigot
approved these changes
Feb 15, 2020
mnkp
reviewed
Feb 15, 2020
mnkp
added
area: GPIO
bug
Disabling gpio interrupts on the pin prior to changing its interrupt type to level-based helps prevent spurious interrupts that would be otherwise observed, if gpio interrupts were originally enabled when gpio_cc32xx_pin_interrupt_configure() is invoked. Fixes zephyrproject-rtos#22847 Signed-off-by: Vincent Wan <vincent.wan@linaro.org>
vanti
force-pushed
the
gpio_test_failed
branch
from
207f715 to
d351b6d
Compare
mnkp
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzing #22847 has shown that spurious interrupts are observed when invoking test_callback for level-based interrupt type. The test hangs due to interrupts being repeatedly fired. This is fixed by performing the following:
Avoid unnecessarily disabling gpio interrupts when firing registered callbacks. This is an issue because gpio_basic_api's test_deprecated test case attempts to disable interrupts on a pin under certain conditions by invoking gpio_pin_configure(), which has no effect given they get re-enabled as soon as the callbacks are done firing.
Disable gpio interrupts prior to changing the interrupt type in gpio_cc32xx_pin_interrupt_configure(), in case interrupts were already enabled by previous test cases.